Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add two missing availability annotations for MTRSubscribeParams properties. #24567

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Add two missing availability annotations for MTRSubscribeParams properties. #24567

merged 1 commit into from
Jan 22, 2023

Conversation

bzbarsky-apple
Copy link
Contributor

These properties used to have different names.

@bzbarsky-apple
Add two missing availability annotations for MTRSubscribeParams prope…
4c11315 
…rties.

These properties used to have different names.
@github-actions
Copy link

github-actions bot commented Jan 21, 2023 •
edited
Loading

PR #24567: Size comparison from 7b99e63 to 4c11315

Increases (7 builds for cc13x2_26x2, esp32, nrfconnect, telink)
platform target config section 7b99e63 4c11315 change % change
cc13x2_26x2 lock-mtd LP_CC2652R7 (read only) 659791 659799 8 0.0
.text 556744 556752 8 0.0
esp32 all-clusters-app c3devkit (read only) 1040858 1040860 2 0.0
.flash.text 1040858 1040860 2 0.0
m5stack (read/write) 496971 496975 4 0.0
.flash.rodata 248240 248244 4 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 803692 803696 4 0.0
telink all-clusters-app tlsr9518adk80d text 688072 688074 2 0.0
light-switch-app tlsr9518adk80d (read/write) 884808 884816 8 0.0
text 596460 596462 2 0.0
ota-requestor-app tlsr9518adk80d text 607556 607558 2 0.0
Decreases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
platform target config section 7b99e63 4c11315 change % change
bl602 lighting-app bl602 .text 1021576 1021572 -4 -0.0
bl602+rpc (read/write) 1389614 1389606 -8 -0.0
.text 1052506 1052504 -2 -0.0
bl702 lighting-app bl702 .debug_info 39970355 39970354 -1 -0.0
.text 954472 954470 -2 -0.0
bl702+rpc .debug_info 44363889 44363888 -1 -0.0
.text 1031622 1031620 -2 -0.0
cc13x2_26x2 lock-mtd LP_CC2652R7 (read/write) 184800 184792 -8 -0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1109560 1109544 -16 -0.0
text 773096 773092 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27390141 27390140 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22418845 22418844 -1 -0.0
telink all-clusters-minimal-app tlsr9518adk80d (read/write) 963728 963720 -8 -0.0
text 651364 651360 -4 -0.0
contact-sensor-app tlsr9518adk80d (read/write) 868360 868352 -8 -0.0
text 581862 581860 -2 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 7b99e63 4c11315 change % change
bl602 lighting-app bl602 (read/write) 1344182 1344182 0 0.0
.bss 94730 94730 0 0.0
.data 9736 9736 0 0.0
.text 1021576 1021572 -4 -0.0
bl602+rpc (read/write) 1389614 1389606 -8 -0.0
.bss 102778 102778 0 0.0
.data 10120 10120 0 0.0
.text 1052506 1052504 -2 -0.0
bl702 lighting-app bl702 (read/write) 1199547 1199547 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 71181 71181 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4056 4056 0 0.0
.debug_abbrev 1539799 1539799 0 0.0
.debug_aranges 133912 133912 0 0.0
.debug_frame 490852 490852 0 0.0
.debug_info 39970355 39970354 -1 -0.0
.debug_line 5258953 5258953 0 0.0
.debug_loc 3415343 3415343 0 0.0
.debug_ranges 372256 372256 0 0.0
.debug_str 3528015 3528015 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115456 115456 0 0.0
.rsvd 2960 2960 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 570138 570138 0 0.0
.symtab 172576 172576 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
954472 954470 -2 -0.0
bl702+rpc (read/write) 1292319 1292319 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 79229 79229 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4608 4608 0 0.0
.debug_abbrev 1688209 1688209 0 0.0
.debug_aranges 142128 142128 0 0.0
.debug_frame 518516 518516 0 0.0
.debug_info 44363889 44363888 -1 -0.0
.debug_line 5656823 5656823 0 0.0
.debug_loc 3611269 3611269 0 0.0
.debug_ranges 395952 395952 0 0.0
.debug_str 3931149 3931149 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129936 129936 0 0.0
.rsvd 2960 2960 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 630612 630612 0 0.0
.symtab 190896 190896 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3338 3338 0 0.0
.text 0 0 0 0.0
1031622 1031620 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676087 676087 0 0.0
(read/write) 175704 175704 0 0.0
.bss 81484 81484 0 0.0
.data 3384 3384 0 0.0
.rodata 87031 87031 0 0.0
.text 588744 588744 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639727 639727 0 0.0
(read/write) 158224 158224 0 0.0
.bss 80724 80724 0 0.0
.data 3384 3384 0 0.0
.rodata 77119 77119 0 0.0
.text 562284 562284 0 0.0
lock-ftd LP_CC2652R7 (read only) 673803 673803 0 0.0
(read/write) 175524 175524 0 0.0
.bss 79108 79108 0 0.0
.data 3308 3308 0 0.0
.rodata 76099 76099 0 0.0
.text 597224 597224 0 0.0
lock-mtd LP_CC2652R7 (read only) 659791 659799 8 0.0
(read/write) 184800 184792 -8 -0.0
.bss 74372 74372 0 0.0
.data 3308 3308 0 0.0
.rodata 102567 102567 0 0.0
.text 556744 556752 8 0.0
pump-app LP_CC2652R7 (read only) 686803 686803 0 0.0
(read/write) 163252 163252 0 0.0
.bss 79068 79068 0 0.0
.data 3272 3272 0 0.0
.rodata 90227 90227 0 0.0
.text 596096 596096 0 0.0
pump-controller-app LP_CC2652R7 (read only) 672251 672251 0 0.0
(read/write) 177916 177916 0 0.0
.bss 79180 79180 0 0.0
.data 3296 3296 0 0.0
.rodata 86307 86307 0 0.0
.text 585464 585464 0 0.0
shell LP_CC2652R7 (read only) 667350 667350 0 0.0
(read/write) 186512 186512 0 0.0
.bss 83556 83556 0 0.0
.data 3380 3380 0 0.0
.rodata 83774 83774 0 0.0
.text 583260 583260 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 585202 585202 0 0.0
.app_xip_area 461220 461220 0 0.0
.bss 66432 66432 0 0.0
.data 732 732 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588918 588918 0 0.0
.app_xip_area 459640 459640 0 0.0
.bss 71720 71720 0 0.0
.data 740 740 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 550062 550062 0 0.0
.app_xip_area 431576 431576 0 0.0
.bss 60984 60984 0 0.0
.data 688 688 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973444 973444 0 0.0
.bss 147144 147144 0 0.0
.data 2192 2192 0 0.0
.text 824088 824088 0 0.0
BRD4161A+rs911x (read/write) 1036400 1036400 0 0.0
.bss 181632 181632 0 0.0
.data 2036 2036 0 0.0
.text 852712 852712 0 0.0
BRD4187C (read/write) 1150420 1150420 0 0.0
.bss 133644 133644 0 0.0
.data 2540 2540 0 0.0
.text 989640 989640 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064368 1064368 0 0.0
.bss 153152 153152 0 0.0
.data 2044 2044 0 0.0
.text 909152 909152 0 0.0
window-app BRD4187C (read/write) 1143120 1143120 0 0.0
.bss 135060 135060 0 0.0
.data 2564 2564 0 0.0
.text 980900 980900 0 0.0
esp32 all-clusters-app c3devkit (read only) 1040858 1040860 2 0.0
(read/write) 1515322 1515322 0 0.0
.dram0.bss 75848 75848 0 0.0
.dram0.data 13792 13792 0 0.0
.flash.rodata 219456 219456 0 0.0
.flash.text 1040858 1040860 2 0.0
.iram0.text 72896 72896 0 0.0
m5stack (read only) 1092963 1092963 0 0.0
(read/write) 496971 496975 4 0.0
.dram0.bss 80888 80888 0 0.0
.dram0.data 34072 34072 0 0.0
.flash.rodata 248240 248244 4 0.0
.flash.text 1087579 1087579 0 0.0
.iram0.text 124855 124855 0 0.0
k32w contact k32w0+release (read/write) 660328 660328 0 0.0
.bss 77360 77360 0 0.0
.data 2108 2108 0 0.0
.text 561748 561748 0 0.0
light k32w0+release (read/write) 672044 672044 0 0.0
.bss 75144 75144 0 0.0
.data 2064 2064 0 0.0
.text 592108 592108 0 0.0
lock k32w0+release (read/write) 631712 631712 0 0.0
.bss 75912 75912 0 0.0
.data 2084 2084 0 0.0
.text 550988 550988 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10883220 10883220 0 0.0
(read/write) 693432 693432 0 0.0
.bss 34184 34184 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 636976 636976 0 0.0
.dynamic 560 560 0 0.0
.got 14064 14064 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 565284 565284 0 0.0
.text 8675860 8675860 0 0.0
thermostat-no-ble arm64 (read only) 2500644 2500644 0 0.0
(read/write) 144632 144632 0 0.0
.bss 56456 56456 0 0.0
.data 1824 1824 0 0.0
.data.rel.ro 76920 76920 0 0.0
.dynamic 560 560 0 0.0
.got 5392 5392 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150656 150656 0 0.0
.text 2088208 2088208 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2462256 2462256 0 0.0
.bss 215956 215956 0 0.0
.data 5880 5880 0 0.0
.text 1424900 1424900 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1163704 1163704 0 0.0
bss 147056 147056 0 0.0
rodata 132800 132800 0 0.0
text 803692 803696 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1365404 1365404 0 0.0
bss 106356 106356 0 0.0
rodata 210284 210284 0 0.0
text 762928 762928 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1109560 1109544 -16 -0.0
bss 146259 146259 0 0.0
rodata 110080 110080 0 0.0
text 773096 773092 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 841008 841008 0 0.0
(read/write) 1748724 1748724 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 189672 189672 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1248036 1248036 0 0.0
.debug_aranges 111216 111216 0 0.0
.debug_frame 373488 373488 0 0.0
.debug_info 27390141 27390140 -1 -0.0
.debug_line 3761605 3761605 0 0.0
.debug_loc 3646900 3646900 0 0.0
.debug_ranges 356600 356600 0 0.0
.debug_str 3479565 3479565 0 0.0
.heap 841008 841008 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 575175 575175 0 0.0
.symtab 423216 423216 0 0.0
.text 0 0 0 0.0
1548000 1548000 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 841768 841768 0 0.0
(read/write) 1690164 1690164 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188912 188912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233843 1233843 0 0.0
.debug_aranges 110480 110480 0 0.0
.debug_frame 375932 375932 0 0.0
.debug_info 26947749 26947749 0 0.0
.debug_line 3769697 3769697 0 0.0
.debug_loc 3630300 3630300 0 0.0
.debug_ranges 354568 354568 0 0.0
.debug_str 3464371 3464371 0 0.0
.heap 841768 841768 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535555 535555 0 0.0
.symtab 408176 408176 0 0.0
.text 1490200 1490200 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 849944 849944 0 0.0
(read/write) 1610236 1610236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 180936 180936 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2464 2464 0 0.0
.debug_abbrev 1069057 1069057 0 0.0
.debug_aranges 102768 102768 0 0.0
.debug_frame 346508 346508 0 0.0
.debug_info 22418845 22418844 -1 -0.0
.debug_line 3334571 3334571 0 0.0
.debug_loc 3332175 3332175 0 0.0
.debug_ranges 318792 318792 0 0.0
.debug_str 3270170 3270170 0 0.0
.heap 849944 849944 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473496 473496 0 0.0
.symtab 377408 377408 0 0.0
.text 1418448 1418448 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 844960 844960 0 0.0
(read/write) 1644300 1644300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185912 185912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1070405 1070405 0 0.0
.debug_aranges 103152 103152 0 0.0
.debug_frame 348308 348308 0 0.0
.debug_info 22641039 22641039 0 0.0
.debug_line 3336369 3336369 0 0.0
.debug_loc 3353690 3353690 0 0.0
.debug_ranges 320648 320648 0 0.0
.debug_str 3286577 3286577 0 0.0
.heap 844960 844960 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476431 476431 0 0.0
.symtab 379232 379232 0 0.0
.text 1447528 1447528 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147908 1147908 0 0.0
.bss 100668 100668 0 0.0
.data 844 844 0 0.0
.text 595004 595004 0 0.0
lock-app qpg6105+debug (read/write) 1115268 1115268 0 0.0
.bss 97188 97188 0 0.0
.data 856 856 0 0.0
.text 562368 562368 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1025388 1025388 0 0.0
bss 98492 98492 0 0.0
text 688072 688074 2 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963728 963720 -8 -0.0
bss 97680 97680 0 0.0
text 651364 651360 -4 -0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868360 868352 -8 -0.0
bss 89844 89844 0 0.0
text 581862 581860 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884808 884816 8 0.0
bss 89940 89940 0 0.0
text 596460 596462 2 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 963160 963160 0 0.0
bss 97996 97996 0 0.0
text 662466 662466 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898624 898624 0 0.0
bss 90888 90888 0 0.0
text 607556 607558 2 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 888032 888032 0 0.0
bss 91328 91328 0 0.0
text 597224 597224 0 0.0

@andy31415 andy31415 merged commit 8e4265c into project-chip:master Jan 22, 2023
@bzbarsky-apple bzbarsky-apple deleted the add-subscribe-params-annotations branch January 23, 2023 14:01
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
@bzbarsky-apple
Add two missing availability annotations for MTRSubscribeParams prope…
0be4e61 
…rties. (project-chip#24567)

These properties used to have different names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivien-apple vivien-apple vivien-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@rgoliver rgoliver Awaiting requested review from rgoliver

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
api darwin review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bzbarsky-apple @andy31415 @vivien-apple